Commit 57c984f6 authored by Biju Das's avatar Biju Das Committed by Greg Kroah-Hartman
Browse files

tty: serial: sh-sci: Fix sleeping in atomic context 



Fix sleeping in atomic context warning as reported by the Smatch static
checker tool by replacing disable_irq->disable_irq_nosync.

Reported by: Dan Carpenter <dan.carpenter@linaro.org>

Fixes: 8749061b ("tty: serial: sh-sci: Add RZ/G2L SCIFA DMA tx support")
Cc: stable@kernel.org
Signed-off-by: default avatarBiju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20230704154818.406913-1-biju.das.jz@bp.renesas.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9b8fef63

drivers/tty/serial/sh-sci.c

+1 −1
Original line number Diff line number Diff line
@@ -590,7 +590,7 @@ static void sci_start_tx(struct uart_port *port) 
	    dma_submit_error(s->cookie_tx)) {

		if (s->cfg->regtype == SCIx_RZ_SCIFA_REGTYPE)

			/* Switch irq from SCIF to DMA */

			disable_irq(s->irqs[SCIx_TXI_IRQ]);

			disable_irq_nosync(s->irqs[SCIx_TXI_IRQ]);



		s->cookie_tx = 0;

		schedule_work(&s->work_tx);