Commit 57b037db authored by Alistair Popple's avatar Alistair Popple Committed by Andrew Morton
Browse files

mmu_notifiers: fixup comment in mmu_interval_read_begin() 

The comment in mmu_interval_read_begin() refers to a function that doesn't
exist and uses the wrong call-back name.  The op for mmu interval
notifiers is mmu_interval_notifier_ops->invalidate() so fix the comment up
to reflect that.

Link: https://lkml.kernel.org/r/e7a09081b3ac82a03c189409f1262fc2df91071e.1690292440.git-series.apopple@nvidia.com


Signed-off-by: default avatarAlistair Popple <apopple@nvidia.com>
Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Cc: Andrew Donnellan <ajd@linux.ibm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Cc: Frederic Barrat <fbarrat@linux.ibm.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Kevin Tian <kevin.tian@intel.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Nicolin Chen <nicolinc@nvidia.com>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Sean Christopherson <seanjc@google.com>
Cc: SeongJae Park <sj@kernel.org>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Will Deacon <will@kernel.org>
Cc: Zhi Wang <zhi.wang.linux@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 38b14e2e

mm/mmu_notifier.c

+2 −2
Original line number Diff line number Diff line
@@ -199,7 +199,7 @@ mmu_interval_read_begin(struct mmu_interval_notifier *interval_sub) 
	 * invalidate_start/end and is colliding.

	 *

	 * The locking looks broadly like this:

	 *   mn_tree_invalidate_start():          mmu_interval_read_begin():

	 *   mn_itree_inv_start():                 mmu_interval_read_begin():

	 *                                         spin_lock

	 *                                          seq = READ_ONCE(interval_sub->invalidate_seq);

	 *                                          seq == subs->invalidate_seq
@@ -207,7 +207,7 @@ mmu_interval_read_begin(struct mmu_interval_notifier *interval_sub) 
	 *    spin_lock

	 *     seq = ++subscriptions->invalidate_seq

	 *    spin_unlock

	 *     op->invalidate_range():

	 *     op->invalidate():

	 *       user_lock

	 *        mmu_interval_set_seq()

	 *         interval_sub->invalidate_seq = seq