Commit 57a79ce9 authored by Dmitry Baryshkov's avatar Dmitry Baryshkov Committed by Vinod Koul
Browse files

dt-bindings: phy: migrate combo QMP PHY bindings to qcom,sc8280xp-qmp-usb43dp-phy.yaml 



Migrate legacy bindings (described in qcom,sc7180-qmp-usb3-dp-phy.yaml)
to qcom,sc8280xp-qmp-usb43dp-phy.yaml. This removes a need to declare
the child PHY node or split resource regions.

Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20230711120916.4165894-2-dmitry.baryshkov@linaro.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent f5a8ecef

Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml

deleted100644 → 0
+0 −284
Original line number Diff line number Diff line 
# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)



%YAML 1.2

---

$id: http://devicetree.org/schemas/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml#

$schema: http://devicetree.org/meta-schemas/core.yaml#



title: Qualcomm QMP USB3 DP PHY controller (SC7180)



description:

  The QMP PHY controller supports physical layer functionality for a number of

  controllers on Qualcomm chipsets, such as, PCIe, UFS and USB.



  Note that these bindings are for SoCs up to SC8180X. For newer SoCs, see

  qcom,sc8280xp-qmp-usb43dp-phy.yaml.



maintainers:

  - Wesley Cheng <quic_wcheng@quicinc.com>



properties:

  compatible:

    oneOf:

      - enum:

          - qcom,sc7180-qmp-usb3-dp-phy

          - qcom,sc8180x-qmp-usb3-dp-phy

          - qcom,sdm845-qmp-usb3-dp-phy

          - qcom,sm8150-qmp-usb3-dp-phy

          - qcom,sm8250-qmp-usb3-dp-phy

      - items:

          - enum:

              - qcom,sc7280-qmp-usb3-dp-phy

          - const: qcom,sm8250-qmp-usb3-dp-phy



  reg:

    items:

      - description: Address and length of PHY's USB serdes block.

      - description: Address and length of the DP_COM control block.

      - description: Address and length of PHY's DP serdes block.



  reg-names:

    items:

      - const: usb

      - const: dp_com

      - const: dp



  "#address-cells":

    enum: [ 1, 2 ]



  "#size-cells":

    enum: [ 1, 2 ]



  ranges: true



  clocks:

    minItems: 3

    maxItems: 4



  clock-names:

    minItems: 3

    maxItems: 4



  power-domains:

    maxItems: 1



  orientation-switch:

    description: Flag the port as possible handler of orientation switching

    type: boolean



  resets:

    items:

      - description: reset of phy block.

      - description: phy common block reset.



  reset-names:

    items:

      - const: phy

      - const: common



  vdda-phy-supply:

    description:

      Phandle to a regulator supply to PHY core block.



  vdda-pll-supply:

    description:

      Phandle to 1.8V regulator supply to PHY refclk pll block.



  vddp-ref-clk-supply:

    description:

      Phandle to a regulator supply to any specific refclk pll block.



# Required nodes:

patternProperties:

  "^usb3-phy@[0-9a-f]+$":

    type: object

    additionalProperties: false

    description:

      The USB3 PHY.



    properties:

      reg:

        items:

          - description: Address and length of TX.

          - description: Address and length of RX.

          - description: Address and length of PCS.

          - description: Address and length of TX2.

          - description: Address and length of RX2.

          - description: Address and length of pcs_misc.



      clocks:

        items:

          - description: pipe clock



      clock-names:

        deprecated: true

        items:

          - const: pipe0



      clock-output-names:

        items:

          - const: usb3_phy_pipe_clk_src



      '#clock-cells':

        const: 0



      '#phy-cells':

        const: 0



    required:

      - reg

      - clocks

      - '#clock-cells'

      - '#phy-cells'



  "^dp-phy@[0-9a-f]+$":

    type: object

    additionalProperties: false

    description:

      The DP PHY.



    properties:

      reg:

        items:

          - description: Address and length of TX.

          - description: Address and length of RX.

          - description: Address and length of PCS.

          - description: Address and length of TX2.

          - description: Address and length of RX2.



      '#clock-cells':

        const: 1



      '#phy-cells':

        const: 0



    required:

      - reg

      - '#clock-cells'

      - '#phy-cells'



required:

  - compatible

  - reg

  - "#address-cells"

  - "#size-cells"

  - ranges

  - clocks

  - clock-names

  - resets

  - reset-names

  - vdda-phy-supply

  - vdda-pll-supply



allOf:

  - if:

      properties:

        compatible:

          enum:

            - qcom,sc7180-qmp-usb3-dp-phy

            - qcom,sdm845-qmp-usb3-dp-phy

    then:

      properties:

        clocks:

          items:

            - description: Phy aux clock

            - description: Phy config clock

            - description: 19.2 MHz ref clk

            - description: Phy common block aux clock

        clock-names:

          items:

            - const: aux

            - const: cfg_ahb

            - const: ref

            - const: com_aux



  - if:

      properties:

        compatible:

          enum:

            - qcom,sc8180x-qmp-usb3-dp-phy

            - qcom,sm8150-qmp-usb3-dp-phy

    then:

      properties:

        clocks:

          items:

            - description: Phy aux clock

            - description: 19.2 MHz ref clk

            - description: Phy common block aux clock

        clock-names:

          items:

            - const: aux

            - const: ref

            - const: com_aux



  - if:

      properties:

        compatible:

          enum:

            - qcom,sm8250-qmp-usb3-dp-phy

    then:

      properties:

        clocks:

          items:

            - description: Phy aux clock

            - description: Board XO source

            - description: Phy common block aux clock

        clock-names:

          items:

            - const: aux

            - const: ref_clk_src

            - const: com_aux



additionalProperties: false



examples:

  - |

    #include <dt-bindings/clock/qcom,gcc-sdm845.h>

    usb_1_qmpphy: phy-wrapper@88e9000 {

        compatible = "qcom,sdm845-qmp-usb3-dp-phy";

        reg = <0x088e9000 0x18c>,

              <0x088e8000 0x10>,

              <0x088ea000 0x40>;

        reg-names = "usb", "dp_com", "dp";

        #address-cells = <1>;

        #size-cells = <1>;

        ranges = <0x0 0x088e9000 0x2000>;



        clocks = <&gcc GCC_USB3_PRIM_PHY_AUX_CLK>,

                 <&gcc GCC_USB_PHY_CFG_AHB2PHY_CLK>,

                 <&gcc GCC_USB3_PRIM_CLKREF_CLK>,

                 <&gcc GCC_USB3_PRIM_PHY_COM_AUX_CLK>;

        clock-names = "aux", "cfg_ahb", "ref", "com_aux";



        resets = <&gcc GCC_USB3_PHY_PRIM_BCR>,

                 <&gcc GCC_USB3_DP_PHY_PRIM_BCR>;

        reset-names = "phy", "common";



        vdda-phy-supply = <&vdda_usb2_ss_1p2>;

        vdda-pll-supply = <&vdda_usb2_ss_core>;



        orientation-switch;



        usb3-phy@200 {

            reg = <0x200 0x128>,

                  <0x400 0x200>,

                  <0xc00 0x218>,

                  <0x600 0x128>,

                  <0x800 0x200>,

                  <0xa00 0x100>;

            #clock-cells = <0>;

            #phy-cells = <0>;

            clocks = <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>;

            clock-output-names = "usb3_phy_pipe_clk_src";

        };



        dp-phy@88ea200 {

            reg = <0xa200 0x200>,

                  <0xa400 0x200>,

                  <0xaa00 0x200>,

                  <0xa600 0x200>,

                  <0xa800 0x200>;

            #clock-cells = <1>;

            #phy-cells = <0>;

        };

    };

Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml

+44 −2
Original line number Diff line number Diff line
@@ -16,8 +16,14 @@ description: 
properties:

  compatible:

    enum:

      - qcom,sc7180-qmp-usb3-dp-phy

      - qcom,sc7280-qmp-usb3-dp-phy

      - qcom,sc8180x-qmp-usb3-dp-phy

      - qcom,sc8280xp-qmp-usb43dp-phy

      - qcom,sdm845-qmp-usb3-dp-phy

      - qcom,sm6350-qmp-usb3-dp-phy

      - qcom,sm8150-qmp-usb3-dp-phy

      - qcom,sm8250-qmp-usb3-dp-phy

      - qcom,sm8350-qmp-usb3-dp-phy

      - qcom,sm8450-qmp-usb3-dp-phy

      - qcom,sm8550-qmp-usb3-dp-phy
@@ -26,14 +32,17 @@ properties: 
    maxItems: 1



  clocks:

    maxItems: 4

    minItems: 4

    maxItems: 5



  clock-names:

    minItems: 4

    items:

      - const: aux

      - const: ref

      - const: com_aux

      - const: usb3_pipe

      - const: cfg_ahb



  power-domains:

    maxItems: 1
@@ -85,7 +94,6 @@ required: 
  - reg

  - clocks

  - clock-names

  - power-domains

  - resets

  - reset-names

  - vdda-phy-supply
@@ -93,6 +101,40 @@ required: 
  - "#clock-cells"

  - "#phy-cells"



allOf:

  - if:

      properties:

        compatible:

          enum:

            - qcom,sc7180-qmp-usb3-dp-phy

            - qcom,sdm845-qmp-usb3-dp-phy

    then:

      properties:

        clocks:

          maxItems: 5

        clock-names:

          maxItems: 5

    else:

      properties:

        clocks:

          maxItems: 4

        clock-names:

          maxItems: 4



  - if:

      properties:

        compatible:

          enum:

            - qcom,sc8280xp-qmp-usb43dp-phy

            - qcom,sm6350-qmp-usb3-dp-phy

            - qcom,sm8550-qmp-usb3-dp-phy

    then:

      required:

        - power-domains

    else:

      properties:

        power-domains: false



additionalProperties: false



examples: