Commit 579a4e9d authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: ufs: Try harder to change the power mode 



Instead of only retrying the START STOP UNIT command if a unit attention is
reported, repeat it if any SCSI error is reported by the device or if the
command timed out.

Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20221018202958.1902564-8-bvanassche@acm.org


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent dcd5b763

drivers/ufs/core/ufshcd.c

+5 −3
Original line number Diff line number Diff line
@@ -8776,9 +8776,11 @@ static int ufshcd_set_dev_pwr_mode(struct ufs_hba *hba, 
	for (retries = 3; retries > 0; --retries) {

		ret = scsi_execute(sdp, cmd, DMA_NONE, NULL, 0, NULL, &sshdr,

				   HZ, 0, 0, RQF_PM, NULL);

		if (!scsi_status_is_check_condition(ret) ||

				!scsi_sense_valid(&sshdr) ||

				sshdr.sense_key != UNIT_ATTENTION)

		/*

		 * scsi_execute() only returns a negative value if the request

		 * queue is dying.

		 */

		if (ret <= 0)

			break;

	}

	if (ret) {