Commit 5762482f authored by Linus Torvalds's avatar Linus Torvalds
Browse files

vfs: move get_fs_root_and_pwd() to single caller 



Let's not pollute the include files with inline functions that are only
used in a single place.  Especially not if we decide we might want to
change the semantics of said function to make it more efficient..

Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent b7c09ad4

fs/dcache.c

+11 −0
Original line number Diff line number Diff line
@@ -3015,6 +3015,17 @@ char *dentry_path(struct dentry *dentry, char *buf, int buflen) 
	return ERR_PTR(-ENAMETOOLONG);

}



static inline void get_fs_root_and_pwd(struct fs_struct *fs, struct path *root,

				       struct path *pwd)

{

	spin_lock(&fs->lock);

	*root = fs->root;

	path_get(root);

	*pwd = fs->pwd;

	path_get(pwd);

	spin_unlock(&fs->lock);

}



/*

 * NOTE! The user-level library version returns a

 * character pointer. The kernel system call just

include/linux/fs_struct.h

+0 −11
Original line number Diff line number Diff line
@@ -39,17 +39,6 @@ static inline void get_fs_pwd(struct fs_struct *fs, struct path *pwd) 
	spin_unlock(&fs->lock);

}



static inline void get_fs_root_and_pwd(struct fs_struct *fs, struct path *root,

				       struct path *pwd)

{

	spin_lock(&fs->lock);

	*root = fs->root;

	path_get(root);

	*pwd = fs->pwd;

	path_get(pwd);

	spin_unlock(&fs->lock);

}



extern bool current_chrooted(void);



#endif /* _LINUX_FS_STRUCT_H */