Commit 5745b3da authored by Tetsuo Handa's avatar Tetsuo Handa Committed by Dong Chenchen
Browse files

ath9k_htc: fix NULL pointer dereference at ath9k_htc_tx_get_packet()

mainline inclusion
from mainline-v5.17-rc1
commit 8b3046ab
category: bugfix
bugzilla: 189830, https://gitee.com/src-openeuler/kernel/issues/I9HK6T
CVE: CVE-2024-26897

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8b3046abc99eefe11438090bcc4ec3a3994b55d0

--------------------------------

syzbot is reporting lockdep warning at ath9k_wmi_event_tasklet() followed
by kernel panic at get_htc_epid_queue() from ath9k_htc_tx_get_packet() from
ath9k_htc_txstatus() [1], for ath9k_wmi_event_tasklet(WMI_TXSTATUS_EVENTID)
depends on spin_lock_init() from ath9k_init_priv() being already completed.

Since ath9k_wmi_event_tasklet() is set by ath9k_init_wmi() from
ath9k_htc_probe_device(), it is possible that ath9k_wmi_event_tasklet() is
called via tasklet interrupt before spin_lock_init() from ath9k_init_priv()
 from ath9k_init_device() from ath9k_htc_probe_device() is called.

Let's hold ath9k_wmi_event_tasklet(WMI_TXSTATUS_EVENTID) no-op until
ath9k_tx_init() completes.

Link: https://syzkaller.appspot.com/bug?extid=31d54c60c5b254d6f75b

 [1]
Reported-by: default avatarsyzbot <syzbot+31d54c60c5b254d6f75b@syzkaller.appspotmail.com>
Signed-off-by: default avatarTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Tested-by: default avatarsyzbot <syzbot+31d54c60c5b254d6f75b@syzkaller.appspotmail.com>
Signed-off-by: default avatarKalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/77b76ac8-2bee-6444-d26c-8c30858b8daa@i-love.sakura.ne.jp


Conflicts:
        drivers/net/wireless/ath/ath9k/wmi.c
[current version doesnt contain macro data_race()]
Signed-off-by: default avatarDong Chenchen <dongchenchen2@huawei.com>
parent 9ff44822
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment