Commit 571dda6c authored by Jisheng Zhang's avatar Jisheng Zhang Committed by Lorenzo Pieralisi
Browse files

PCI: tegra194: Remove unnecessary MSI enable reg save and restore 

The integrated MSI Receiver enable register is always initialized in
dw_pcie_setup_rc() which is also called in resume code path, so we
don't need to save/restore the enable register during suspend/resume.

Link: https://lore.kernel.org/r/20211226074910.2722-1-jszhang@kernel.org


Signed-off-by: default avatarJisheng Zhang <jszhang@kernel.org>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: default avatarVidya Sagar <vidyas@nvidia.com>
parent 88557685

drivers/pci/controller/dwc/pcie-tegra194.c

+0 −9
Original line number Diff line number Diff line
@@ -186,8 +186,6 @@ 
#define N_FTS_VAL					52

#define FTS_VAL						52



#define PORT_LOGIC_MSI_CTRL_INT_0_EN		0x828



#define GEN3_EQ_CONTROL_OFF			0x8a8

#define GEN3_EQ_CONTROL_OFF_PSET_REQ_VEC_SHIFT	8

#define GEN3_EQ_CONTROL_OFF_PSET_REQ_VEC_MASK	GENMASK(23, 8)
@@ -2189,9 +2187,6 @@ static int tegra194_pcie_suspend_noirq(struct device *dev) 
	if (!pcie->link_state)

		return 0;



	/* Save MSI interrupt vector */

	pcie->msi_ctrl_int = dw_pcie_readl_dbi(&pcie->pci,

					       PORT_LOGIC_MSI_CTRL_INT_0_EN);

	tegra_pcie_downstream_dev_to_D0(pcie);

	tegra194_pcie_pme_turnoff(pcie);

	tegra_pcie_unconfig_controller(pcie);
@@ -2223,10 +2218,6 @@ static int tegra194_pcie_resume_noirq(struct device *dev) 
	if (ret < 0)

		goto fail_host_init;



	/* Restore MSI interrupt vector */

	dw_pcie_writel_dbi(&pcie->pci, PORT_LOGIC_MSI_CTRL_INT_0_EN,

			   pcie->msi_ctrl_int);



	return 0;



fail_host_init: