Commit 57150c40 authored by Rob Herring's avatar Rob Herring Committed by Miquel Raynal
Browse files

mtd: Use of_property_read_bool() for boolean properties 



It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties.
Convert reading boolean properties to to of_property_read_bool().

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20230310144716.1543995-1-robh@kernel.org
parent 75f32f4b

drivers/mtd/devices/spear_smi.c

+2 −2
Original line number Diff line number Diff line
@@ -820,8 +820,8 @@ static int spear_smi_probe_config_dt(struct platform_device *pdev, 
		pdata->board_flash_info->mem_base = be32_to_cpup(&addr[0]);

		pdata->board_flash_info->size = be32_to_cpup(&addr[1]);



		if (of_get_property(pp, "st,smi-fast-mode", NULL))

			pdata->board_flash_info->fast_mode = 1;

		pdata->board_flash_info->fast_mode =

			of_property_read_bool(pp, "st,smi-fast-mode");



		i++;

	}

drivers/mtd/maps/sun_uflash.c

+1 −1
Original line number Diff line number Diff line
@@ -112,7 +112,7 @@ static int uflash_probe(struct platform_device *op) 
	/* Flashprom must have the "user" property in order to

	 * be used by this driver.

	 */

	if (!of_find_property(dp, "user", NULL))

	if (!of_property_read_bool(dp, "user"))

		return -ENODEV;



	return uflash_devinit(op, dp);

drivers/mtd/mtdcore.c

+1 −1
Original line number Diff line number Diff line
@@ -738,7 +738,7 @@ int add_mtd_device(struct mtd_info *mtd) 


	mutex_unlock(&mtd_table_mutex);



	if (of_find_property(mtd_get_of_node(mtd), "linux,rootfs", NULL)) {

	if (of_property_read_bool(mtd_get_of_node(mtd), "linux,rootfs")) {

		if (IS_BUILTIN(CONFIG_MTD)) {

			pr_info("mtd: setting mtd%d (%s) as root device\n", mtd->index, mtd->name);

			ROOT_DEV = MKDEV(MTD_BLOCK_MAJOR, mtd->index);

drivers/mtd/nand/raw/fsmc_nand.c

+1 −1
Original line number Diff line number Diff line
@@ -880,7 +880,7 @@ static int fsmc_nand_probe_config_dt(struct platform_device *pdev, 
		}

	}



	if (of_get_property(np, "nand-skip-bbtscan", NULL))

	if (of_property_read_bool(np, "nand-skip-bbtscan"))

		nand->options |= NAND_SKIP_BBTSCAN;



	host->dev_timings = devm_kzalloc(&pdev->dev,

drivers/mtd/nand/raw/nand_macronix.c

+2 −3
Original line number Diff line number Diff line
@@ -93,14 +93,13 @@ static void macronix_nand_onfi_init(struct nand_chip *chip) 
	struct nand_parameters *p = &chip->parameters;

	struct nand_onfi_vendor_macronix *mxic;

	struct device_node *dn = nand_get_flash_node(chip);

	int rand_otp = 0;

	int rand_otp;

	int ret;



	if (!p->onfi)

		return;



	if (of_find_property(dn, "mxic,enable-randomizer-otp", NULL))

		rand_otp = 1;

	rand_otp = of_property_read_bool(dn, "mxic,enable-randomizer-otp");



	mxic = (struct nand_onfi_vendor_macronix *)p->onfi->vendor;

	/* Subpage write is prohibited in randomizer operatoin */