Commit 57128e98 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

tls: rx: fix the NoPad getsockopt 



Maxim reports do_tls_getsockopt_no_pad() will
always return an error. Indeed looks like refactoring
gone wrong - remove err and use value.

Reported-by: default avatarMaxim Mikityanskiy <maximmi@nvidia.com>
Fixes: 88527790 ("tls: rx: add sockopt for enabling optimistic decrypt with TLS 1.3")
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent bb56cea9

net/tls/tls_main.c

+4 −5
Original line number Diff line number Diff line
@@ -539,8 +539,7 @@ static int do_tls_getsockopt_no_pad(struct sock *sk, char __user *optval, 
				    int __user *optlen)

{

	struct tls_context *ctx = tls_get_ctx(sk);

	unsigned int value;

	int err, len;

	int value, len;



	if (ctx->prot_info.version != TLS_1_3_VERSION)

		return -EINVAL;
@@ -551,12 +550,12 @@ static int do_tls_getsockopt_no_pad(struct sock *sk, char __user *optval, 
		return -EINVAL;



	lock_sock(sk);

	err = -EINVAL;

	value = -EINVAL;

	if (ctx->rx_conf == TLS_SW || ctx->rx_conf == TLS_HW)

		value = ctx->rx_no_pad;

	release_sock(sk);

	if (err)

		return err;

	if (value < 0)

		return value;



	if (put_user(sizeof(value), optlen))

		return -EFAULT;