Commit 56fb5177 authored by Tomer Tayar's avatar Tomer Tayar Committed by Oded Gabbay
Browse files

habanalabs: fix rc when new CPUCP opcodes are not supported 



When the new CPUCP opcodes are not supported and a CPUCP packet fails,
the return value is the F/W error resposone which is a positive value.
If this packet is sent from IOCTL and the positive value is used, the
ICOTL will not be considered as unsuccessful.

Signed-off-by: default avatarTomer Tayar <ttayar@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 6825b5f8

drivers/misc/habanalabs/common/firmware_if.c

+1 −0
Original line number Diff line number Diff line
@@ -324,6 +324,7 @@ int hl_fw_send_cpu_message(struct hl_device *hdev, u32 hw_queue_id, u32 *msg, 


		if (!prop->supports_advanced_cpucp_rc) {

			dev_dbg(hdev->dev, "F/W ERROR %d for CPU packet %d\n", rc, opcode);

			rc = -EIO;

			goto scrub_descriptor;

		}