Commit 56fa9d07 authored by Qu Wenruo's avatar Qu Wenruo Committed by Chris Mason
Browse files

btrfs: qgroup: Check if qgroup reserved space leaked 



Add check at btrfs_destroy_inode() time to detect qgroup reserved space
leak.

Signed-off-by: default avatarQu Wenruo <quwenruo@cn.fujitsu.com>
Signed-off-by: default avatarChris Mason <clm@fb.com>
parent 51773bec

fs/btrfs/inode.c

+1 −0
Original line number Diff line number Diff line
@@ -9108,6 +9108,7 @@ void btrfs_destroy_inode(struct inode *inode) 
			btrfs_put_ordered_extent(ordered);

		}

	}

	btrfs_qgroup_check_reserved_leak(inode);

	inode_tree_del(inode);

	btrfs_drop_extent_cache(inode, 0, (u64)-1, 0);

free:

fs/btrfs/qgroup.c

+32 −0
Original line number Diff line number Diff line
@@ -2645,3 +2645,35 @@ void btrfs_qgroup_free_meta(struct btrfs_root *root, int num_bytes) 
	atomic_sub(num_bytes, &root->qgroup_meta_rsv);

	qgroup_free(root, num_bytes);

}



/*

 * Check qgroup reserved space leaking, normally at destory inode

 * time

 */

void btrfs_qgroup_check_reserved_leak(struct inode *inode)

{

	struct extent_changeset changeset;

	struct ulist_node *unode;

	struct ulist_iterator iter;

	int ret;



	changeset.bytes_changed = 0;

	changeset.range_changed = ulist_alloc(GFP_NOFS);

	if (WARN_ON(!changeset.range_changed))

		return;



	ret = clear_record_extent_bits(&BTRFS_I(inode)->io_tree, 0, (u64)-1,

			EXTENT_QGROUP_RESERVED, GFP_NOFS, &changeset);



	WARN_ON(ret < 0);

	if (WARN_ON(changeset.bytes_changed)) {

		ULIST_ITER_INIT(&iter);

		while ((unode = ulist_next(changeset.range_changed, &iter))) {

			btrfs_warn(BTRFS_I(inode)->root->fs_info,

				"leaking qgroup reserved space, ino: %lu, start: %llu, end: %llu",

				inode->i_ino, unode->val, unode->aux);

		}

		qgroup_free(BTRFS_I(inode)->root, changeset.bytes_changed);

	}

	ulist_free(changeset.range_changed);

}

fs/btrfs/qgroup.h

+1 −0
Original line number Diff line number Diff line
@@ -105,4 +105,5 @@ int btrfs_qgroup_free_data(struct inode *inode, u64 start, u64 len); 
int btrfs_qgroup_reserve_meta(struct btrfs_root *root, int num_bytes);

void btrfs_qgroup_free_meta_all(struct btrfs_root *root);

void btrfs_qgroup_free_meta(struct btrfs_root *root, int num_bytes);

void btrfs_qgroup_check_reserved_leak(struct inode *inode);

#endif /* __BTRFS_QGROUP__ */