Commit 56e4da66 authored by Maxim Mikityanskiy's avatar Maxim Mikityanskiy Committed by Saeed Mahameed
Browse files

net/mlx5e: Move the TLS resync check out of the function 



Before this patch, mlx5e_ktls_tx_handle_resync_dump_comp checked for
resync_dump_frag_page. It happened for all WQEs without an SKB,
including padding WQEs, and required a function call. Normally, padding
WQEs happen more often than TLS resyncs. Take this check out of the
function and put it to an inline function to save a call on all padding
WQEs.

Signed-off-by: default avatarMaxim Mikityanskiy <maximmi@mellanox.com>
Reviewed-by: default avatarTariq Toukan <tariqt@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 97e3afd6

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c

+0 −3
Original line number Diff line number Diff line
@@ -345,9 +345,6 @@ void mlx5e_ktls_tx_handle_resync_dump_comp(struct mlx5e_txqsq *sq, 
	struct mlx5e_sq_stats *stats;

	struct mlx5e_sq_dma *dma;



	if (!wi->resync_dump_frag_page)

		return;



	dma = mlx5e_dma_get(sq, (*dma_fifo_cc)++);

	stats = sq->stats;

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_txrx.h

+11 −3
Original line number Diff line number Diff line
@@ -29,9 +29,17 @@ void mlx5e_ktls_handle_get_psv_completion(struct mlx5e_icosq_wqe_info *wi, 
void mlx5e_ktls_tx_handle_resync_dump_comp(struct mlx5e_txqsq *sq,

					   struct mlx5e_tx_wqe_info *wi,

					   u32 *dma_fifo_cc);

static inline void

mlx5e_ktls_tx_try_handle_resync_dump_comp(struct mlx5e_txqsq *sq,

					  struct mlx5e_tx_wqe_info *wi,

					  u32 *dma_fifo_cc)

{

	if (unlikely(wi->resync_dump_frag_page))

		mlx5e_ktls_tx_handle_resync_dump_comp(sq, wi, dma_fifo_cc);

}

#else

static inline void

mlx5e_ktls_tx_handle_resync_dump_comp(struct mlx5e_txqsq *sq,

mlx5e_ktls_tx_try_handle_resync_dump_comp(struct mlx5e_txqsq *sq,

					  struct mlx5e_tx_wqe_info *wi,

					  u32 *dma_fifo_cc)

{

drivers/net/ethernet/mellanox/mlx5/core/en_tx.c

+2 −2
Original line number Diff line number Diff line
@@ -545,7 +545,7 @@ bool mlx5e_poll_tx_cq(struct mlx5e_cq *cq, int napi_budget) 
			sqcc += wi->num_wqebbs;



			if (unlikely(!skb)) {

				mlx5e_ktls_tx_handle_resync_dump_comp(sq, wi, &dma_fifo_cc);

				mlx5e_ktls_tx_try_handle_resync_dump_comp(sq, wi, &dma_fifo_cc);

				continue;

			}
@@ -610,7 +610,7 @@ void mlx5e_free_txqsq_descs(struct mlx5e_txqsq *sq) 
		sqcc += wi->num_wqebbs;



		if (!skb) {

			mlx5e_ktls_tx_handle_resync_dump_comp(sq, wi, &dma_fifo_cc);

			mlx5e_ktls_tx_try_handle_resync_dump_comp(sq, wi, &dma_fifo_cc);

			continue;

		}