Commit 56db004a authored by Anastasia Kovaleva's avatar Anastasia Kovaleva Committed by Wang Liang
Browse files

net: Fix an unsafe loop on the list 

stable inclusion
from stable-v5.10.227
commit 68ad5da6ca630a276f0a5c924179e57724d00013
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/IAYRDW
CVE: CVE-2024-50024

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=68ad5da6ca630a276f0a5c924179e57724d00013



--------------------------------

commit 1dae9f1187189bc09ff6d25ca97ead711f7e26f9 upstream.

The kernel may crash when deleting a genetlink family if there are still
listeners for that family:

Oops: Kernel access of bad area, sig: 11 [#1]
  ...
  NIP [c000000000c080bc] netlink_update_socket_mc+0x3c/0xc0
  LR [c000000000c0f764] __netlink_clear_multicast_users+0x74/0xc0
  Call Trace:
__netlink_clear_multicast_users+0x74/0xc0
genl_unregister_family+0xd4/0x2d0

Change the unsafe loop on the list to a safe one, because inside the
loop there is an element removal from this list.

Fixes: b8273570 ("genetlink: fix netns vs. netlink table locking (2)")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarAnastasia Kovaleva <a.kovaleva@yadro.com>
Reviewed-by: default avatarDmitry Bogdanov <d.bogdanov@yadro.com>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20241003104431.12391-1-a.kovaleva@yadro.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarWang Liang <wangliang74@huawei.com>
parent 1a47bbfa

include/net/sock.h

+2 −0
Original line number Diff line number Diff line
@@ -857,6 +857,8 @@ static inline void sk_add_bind_node(struct sock *sk, 
	hlist_for_each_entry_safe(__sk, tmp, list, sk_node)

#define sk_for_each_bound(__sk, list) \

	hlist_for_each_entry(__sk, list, sk_bind_node)

#define sk_for_each_bound_safe(__sk, tmp, list) \

	hlist_for_each_entry_safe(__sk, tmp, list, sk_bind_node)



/**

 * sk_for_each_entry_offset_rcu - iterate over a list at a given struct offset

net/netlink/af_netlink.c

+2 −1
Original line number Diff line number Diff line
@@ -2155,8 +2155,9 @@ void __netlink_clear_multicast_users(struct sock *ksk, unsigned int group) 
{

	struct sock *sk;

	struct netlink_table *tbl = &nl_table[ksk->sk_protocol];

	struct hlist_node *tmp;



	sk_for_each_bound(sk, &tbl->mc_list)

	sk_for_each_bound_safe(sk, tmp, &tbl->mc_list)

		netlink_update_socket_mc(nlk_sk(sk), group, 0);

}