Commit 56d0d0b9 authored by Li Zhong's avatar Li Zhong Committed by Theodore Ts'o
Browse files

ext4: check the return value of ext4_xattr_inode_dec_ref() 



Check the return value of ext4_xattr_inode_dec_ref(), which could
return error code and need to be warned.

Signed-off-by: default avatarLi Zhong <floridsleeves@gmail.com>
Link: https://lore.kernel.org/r/20220917002816.3804400-1-floridsleeves@gmail.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 71df9683

fs/ext4/xattr.c

+2 −1
Original line number Diff line number Diff line
@@ -1540,7 +1540,8 @@ static int ext4_xattr_inode_lookup_create(handle_t *handle, struct inode *inode, 


	err = ext4_xattr_inode_write(handle, ea_inode, value, value_len);

	if (err) {

		ext4_xattr_inode_dec_ref(handle, ea_inode);

		if (ext4_xattr_inode_dec_ref(handle, ea_inode))

			ext4_warning_inode(ea_inode, "cleanup dec ref error %d", err);

		iput(ea_inode);

		return err;

	}