Commit 569f98b3 authored by Petr Machata's avatar Petr Machata Committed by Jakub Kicinski
Browse files

mlxsw: spectrum: Drop unused functions mlxsw_sp_port_lower_dev_hold/_put() 



As of commit 151b89f6 ("mlxsw: spectrum_router: Reuse work neighbor
initialization in work scheduler"), the functions
mlxsw_sp_port_lower_dev_hold() and mlxsw_sp_port_dev_put() have no users.
Drop them.

Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/d0adcd7cb4ea19416294a0f861100edba84c9f36.1690471774.git.petrm@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5027d54a

drivers/net/ethernet/mellanox/mlxsw/spectrum.c

+0 −17
Original line number Diff line number Diff line
@@ -4112,23 +4112,6 @@ struct mlxsw_sp_port *mlxsw_sp_port_dev_lower_find_rcu(struct net_device *dev) 
	return (struct mlxsw_sp_port *)priv.data;

}



struct mlxsw_sp_port *mlxsw_sp_port_lower_dev_hold(struct net_device *dev)

{

	struct mlxsw_sp_port *mlxsw_sp_port;



	rcu_read_lock();

	mlxsw_sp_port = mlxsw_sp_port_dev_lower_find_rcu(dev);

	if (mlxsw_sp_port)

		dev_hold(mlxsw_sp_port->dev);

	rcu_read_unlock();

	return mlxsw_sp_port;

}



void mlxsw_sp_port_dev_put(struct mlxsw_sp_port *mlxsw_sp_port)

{

	dev_put(mlxsw_sp_port->dev);

}



int mlxsw_sp_parsing_depth_inc(struct mlxsw_sp *mlxsw_sp)

{

	char mprs_pl[MLXSW_REG_MPRS_LEN];

drivers/net/ethernet/mellanox/mlxsw/spectrum.h

+0 −2
Original line number Diff line number Diff line
@@ -720,8 +720,6 @@ int mlxsw_sp_txhdr_ptp_data_construct(struct mlxsw_core *mlxsw_core, 
bool mlxsw_sp_port_dev_check(const struct net_device *dev);

struct mlxsw_sp *mlxsw_sp_lower_get(struct net_device *dev);

struct mlxsw_sp_port *mlxsw_sp_port_dev_lower_find(struct net_device *dev);

struct mlxsw_sp_port *mlxsw_sp_port_lower_dev_hold(struct net_device *dev);

void mlxsw_sp_port_dev_put(struct mlxsw_sp_port *mlxsw_sp_port);

struct mlxsw_sp_port *mlxsw_sp_port_dev_lower_find_rcu(struct net_device *dev);

int mlxsw_sp_parsing_depth_inc(struct mlxsw_sp *mlxsw_sp);

void mlxsw_sp_parsing_depth_dec(struct mlxsw_sp *mlxsw_sp);