Commit 5696e4aa authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (pwm-fan) Check return value from devm_add_action_or_reset 



devm_add_action_or_reset() can fail due to a memory allocation failure.
Check for it and return the error if that happens.

Fixes: 37bcec5d ("hwmon: (pwm-fan) Use devm_thermal_of_cooling_device_register")
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent b9bb92e1

drivers/hwmon/pwm-fan.c

+7 −3
Original line number Diff line number Diff line
@@ -320,8 +320,10 @@ static int pwm_fan_probe(struct platform_device *pdev) 
			dev_err(dev, "Failed to enable fan supply: %d\n", ret);

			return ret;

		}

		devm_add_action_or_reset(dev, pwm_fan_regulator_disable,

		ret = devm_add_action_or_reset(dev, pwm_fan_regulator_disable,

					       ctx->reg_en);

		if (ret)

			return ret;

	}



	ctx->pwm_value = MAX_PWM;
@@ -337,7 +339,9 @@ static int pwm_fan_probe(struct platform_device *pdev) 
		return ret;

	}

	timer_setup(&ctx->rpm_timer, sample_timer, 0);

	devm_add_action_or_reset(dev, pwm_fan_pwm_disable, ctx);

	ret = devm_add_action_or_reset(dev, pwm_fan_pwm_disable, ctx);

	if (ret)

		return ret;



	of_property_read_u32(dev->of_node, "pulses-per-revolution", &ppr);

	ctx->pulses_per_revolution = ppr;