Commit 5692900b authored by Yang Yingliang's avatar Yang Yingliang Committed by Wolfram Sang
Browse files

i2c: meson: fix missing clk_disable_unprepare() on error in meson_i2c_probe() 



Fix the missing clk_disable_unprepare() before return
from meson_i2c_probe() in the error handling case.

Fixes: a57f9b4d ("i2c: meson: Use 50% duty cycle for I2C clock")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarNeil Armstrong <narmstrong@baylibre.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 32d45361

drivers/i2c/busses/i2c-meson.c

+3 −1
Original line number Diff line number Diff line
@@ -520,8 +520,10 @@ static int meson_i2c_probe(struct platform_device *pdev) 
	meson_i2c_set_mask(i2c, REG_SLAVE_ADDR,

			   REG_SLV_SDA_FILTER_MASK | REG_SLV_SCL_FILTER_MASK, 0);



	if (!i2c->data->set_clk_div)

	if (!i2c->data->set_clk_div) {

		clk_disable_unprepare(i2c->clk);

		return -EINVAL;

	}

	i2c->data->set_clk_div(i2c, timings.bus_freq_hz);



	ret = i2c_add_adapter(&i2c->adap);