Commit 568e7142 authored by wengjianfeng's avatar wengjianfeng Committed by Jakub Kicinski
Browse files

nfc: st95hf: remove unnecessary assignment and label 



In function st95hf_in_send_cmd, the variable rc is assigned then goto
error label, which just returns rc, so we use return to replace it.
Since error label only used once in the function, so we remove error label.

Signed-off-by: default avatarwengjianfeng <wengjianfeng@yulong.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Link: https://lore.kernel.org/r/20210526005651.12652-1-samirweng1979@163.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e4e92ee7

drivers/nfc/st95hf/core.c

+2 −5
Original line number Diff line number Diff line
@@ -926,10 +926,8 @@ static int st95hf_in_send_cmd(struct nfc_digital_dev *ddev, 
	int len_data_to_tag = 0;



	skb_resp = nfc_alloc_recv_skb(MAX_RESPONSE_BUFFER_SIZE, GFP_KERNEL);

	if (!skb_resp) {

		rc = -ENOMEM;

		goto error;

	}

	if (!skb_resp)

		return -ENOMEM;



	switch (stcontext->current_rf_tech) {

	case NFC_DIGITAL_RF_TECH_106A:
@@ -986,7 +984,6 @@ static int st95hf_in_send_cmd(struct nfc_digital_dev *ddev, 


free_skb_resp:

	kfree_skb(skb_resp);

error:

	return rc;

}