Commit 56214b31 authored by Chengchang Tang's avatar Chengchang Tang Committed by Juan Zhou
Browse files

RDMA/hns: Fix signed-unsigned mixed comparisons 

mainline inclusion
from mainline-v6.7-rc1
commit b5f9efff101b06fd06a5e280a2b00b1335f5f476
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I8E9OJ
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b5f9efff101b06fd06a5e280a2b00b1335f5f476



----------------------------------------------------------------------

The ib_mtu_enum_to_int() and uverbs_attr_get_len() may returns a negative
value. In this case, mixed comparisons of signed and unsigned types will
throw wrong results.

This patch adds judgement for this situation.

Fixes: 30b70788 ("RDMA/hns: Support inline data in extented sge space for RC")
Signed-off-by: default avatarChengchang Tang <tangchengchang@huawei.com>
Signed-off-by: default avatarJunxian Huang <huangjunxian6@hisilicon.com>
Link: https://lore.kernel.org/r/20231017125239.164455-4-huangjunxian6@hisilicon.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarJuan Zhou <zhoujuan51@h-partners.com>
parent 497a5440

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+1 −1
Original line number Diff line number Diff line
@@ -282,7 +282,7 @@ static bool check_inl_data_len(struct hns_roce_qp *qp, unsigned int len) 
	struct hns_roce_dev *hr_dev = to_hr_dev(qp->ibqp.device);

	int mtu = ib_mtu_enum_to_int(qp->path_mtu);



	if (len > qp->max_inline_data || len > mtu) {

	if (mtu < 0 || len > qp->max_inline_data || len > mtu) {

		ibdev_err(&hr_dev->ib_dev,

			  "invalid length of data, data len = %u, max inline len = %u, path mtu = %d.\n",

			  len, qp->max_inline_data, mtu);