Commit 560ac051 authored by Namjae Jeon's avatar Namjae Jeon
Browse files

ksmbd: remove unneeded NULL check in the list iterator 



Remove unneeded NULL check in the list iterator. And use
list_for_each_entry_safe instead of list_for_each_safe.

Signed-off-by: default avatarNamjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent ee81cae1

fs/cifsd/mgmt/user_session.c

+6 −9
Original line number Diff line number Diff line
@@ -30,17 +30,14 @@ struct ksmbd_session_rpc { 


static void free_channel_list(struct ksmbd_session *sess)

{

	struct channel *chann;

	struct list_head *tmp, *t;

	struct channel *chann, *tmp;



	list_for_each_safe(tmp, t, &sess->ksmbd_chann_list) {

		chann = list_entry(tmp, struct channel, chann_list);

		if (chann) {

	list_for_each_entry_safe(chann, tmp, &sess->ksmbd_chann_list,

				 chann_list) {

		list_del(&chann->chann_list);

		kfree(chann);

	}

}

}



static void __session_rpc_close(struct ksmbd_session *sess,

				struct ksmbd_session_rpc *entry)

fs/cifsd/smb2pdu.c

+1 −1
Original line number Diff line number Diff line
@@ -76,7 +76,7 @@ struct channel *lookup_chann_list(struct ksmbd_session *sess, struct ksmbd_conn 
	struct channel *chann;



	list_for_each_entry(chann, &sess->ksmbd_chann_list, chann_list) {

		if (chann && chann->conn == conn)

		if (chann->conn == conn)

			return chann;

	}