Commit 55e39185 authored by Namhyung Kim's avatar Namhyung Kim Committed by Arnaldo Carvalho de Melo
Browse files

perf lock contention: Fix to save callstack for the default modified 



The previous change missed to set the con->save_callstack for the
LOCK_AGGR_CALLER mode resulting in no caller information.

Fixes: ebab2916 ("perf lock contention: Support filters for different aggregation")
Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Cc: Hao Luo <haoluo@google.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Song Liu <song@kernel.org>
Cc: Waiman Long <longman@redhat.com>
Cc: Will Deacon <will@kernel.org>
Cc: bpf@vger.kernel.org
Link: https://lore.kernel.org/r/20230207002403.63590-2-namhyung@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 34266f90

tools/perf/builtin-lock.c

+3 −0
Original line number Diff line number Diff line
@@ -1806,6 +1806,9 @@ static int __cmd_contention(int argc, const char **argv) 
	con.aggr_mode = aggr_mode = show_thread_stats ? LOCK_AGGR_TASK :

		show_lock_addrs ? LOCK_AGGR_ADDR : LOCK_AGGR_CALLER;



	if (con.aggr_mode == LOCK_AGGR_CALLER)

		con.save_callstack = true;



	/* for lock function check */

	symbol_conf.sort_by_name = true;

	symbol_conf.allow_aliases = true;