Unverified Commit 55ace1cb authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!9161 xfs: don't use current->journal_info 

Merge Pull Request from: @ci-robot 
 
PR sync from: Zhihao Cheng <chengzhihao@huaweicloud.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/OWBYCZSNE5TZX4MIZAR5QIZFVVSEWFCA/ 
 
https://gitee.com/openeuler/kernel/issues/IA6CG1 
 
Link:https://gitee.com/openeuler/kernel/pulls/9161

 

Reviewed-by: default avatarZhang Peng <zhangpeng362@huawei.com>
Signed-off-by: default avatarZhang Peng <zhangpeng362@huawei.com>
parents 986fcc8f 8c29e354

fs/xfs/scrub/common.c

+1 −3
Original line number Diff line number Diff line
@@ -978,9 +978,7 @@ xchk_irele( 
	struct xfs_scrub	*sc,

	struct xfs_inode	*ip)

{

	if (current->journal_info != NULL) {

		ASSERT(current->journal_info == sc->tp);



	if (sc->tp) {

		/*

		 * If we are in a transaction, we /cannot/ drop the inode

		 * ourselves, because the VFS will trigger writeback, which

fs/xfs/xfs_aops.c

+0 −7
Original line number Diff line number Diff line
@@ -477,13 +477,6 @@ xfs_vm_writepages( 
{

	struct xfs_writepage_ctx wpc = { };



	/*

	 * Writing back data in a transaction context can result in recursive

	 * transactions. This is bad, so issue a warning and get out of here.

	 */

	if (WARN_ON_ONCE(current->journal_info))

		return 0;



	xfs_iflags_clear(XFS_I(mapping->host), XFS_ITRUNCATED);

	return iomap_writepages(mapping, wbc, &wpc.ctx, &xfs_writeback_ops);

}

fs/xfs/xfs_icache.c

+5 −3
Original line number Diff line number Diff line
@@ -2037,8 +2037,10 @@ xfs_inodegc_want_queue_work( 
 *  - Memory shrinkers queued the inactivation worker and it hasn't finished.

 *  - The queue depth exceeds the maximum allowable percpu backlog.

 *

 * Note: If the current thread is running a transaction, we don't ever want to

 * wait for other transactions because that could introduce a deadlock.

 * Note: If we are in a NOFS context here (e.g. current thread is running a

 * transaction) the we don't want to block here as inodegc progress may require

 * filesystem resources we hold to make progress and that could result in a

 * deadlock. Hence we skip out of here if we are in a scoped NOFS context.

 */

static inline bool

xfs_inodegc_want_flush_work(
@@ -2046,7 +2048,7 @@ xfs_inodegc_want_flush_work( 
	unsigned int		items,

	unsigned int		shrinker_hits)

{

	if (current->journal_info)

	if (current->flags & PF_MEMALLOC_NOFS)

		return false;



	if (shrinker_hits > 0)

fs/xfs/xfs_trans.h

+1 −8
Original line number Diff line number Diff line
@@ -277,19 +277,14 @@ static inline void 
xfs_trans_set_context(

	struct xfs_trans	*tp)

{

	ASSERT(current->journal_info == NULL);

	tp->t_pflags = memalloc_nofs_save();

	current->journal_info = tp;

}



static inline void

xfs_trans_clear_context(

	struct xfs_trans	*tp)

{

	if (current->journal_info == tp) {

	memalloc_nofs_restore(tp->t_pflags);

		current->journal_info = NULL;

	}

}



static inline void
@@ -297,10 +292,8 @@ xfs_trans_switch_context( 
	struct xfs_trans	*old_tp,

	struct xfs_trans	*new_tp)

{

	ASSERT(current->journal_info == old_tp);

	new_tp->t_pflags = old_tp->t_pflags;

	old_tp->t_pflags = 0;

	current->journal_info = new_tp;

}



#endif	/* __XFS_TRANS_H__ */