Commit 55650b2f authored by Anuradha Weeraman's avatar Anuradha Weeraman Committed by Christian Brauner
Browse files

fs/open.c: Fix W=1 kernel doc warnings 



fs/open.c: In functions 'setattr_vfsuid' and 'setattr_vfsgid':
 warning: Function parameter or member 'attr' not described
 - Fix warning by removing kernel-doc for these as they are static
   inline functions and not required to be exposed via kernel-doc.

fs/open.c:
 warning: Excess function parameter 'opened' description in 'finish_open'
 warning: Excess function parameter 'cred' description in 'vfs_open'
 - Fix by removing the parameters from the kernel-doc as they are no
   longer required by the function.

Signed-off-by: default avatarAnuradha Weeraman <anuradha@debian.org>
Message-Id: <20230506182928.384105-1-anuradha@debian.org>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent c642256b

fs/open.c

+2 −10
Original line number Diff line number Diff line
@@ -700,10 +700,7 @@ SYSCALL_DEFINE2(chmod, const char __user *, filename, umode_t, mode) 
	return do_fchmodat(AT_FDCWD, filename, mode);

}



/**

 * setattr_vfsuid - check and set ia_fsuid attribute

 * @kuid: new inode owner

 *

/*

 * Check whether @kuid is valid and if so generate and set vfsuid_t in

 * ia_vfsuid.

 *
@@ -718,10 +715,7 @@ static inline bool setattr_vfsuid(struct iattr *attr, kuid_t kuid) 
	return true;

}



/**

 * setattr_vfsgid - check and set ia_fsgid attribute

 * @kgid: new inode owner

 *

/*

 * Check whether @kgid is valid and if so generate and set vfsgid_t in

 * ia_vfsgid.

 *
@@ -989,7 +983,6 @@ static int do_dentry_open(struct file *f, 
 * @file: file pointer

 * @dentry: pointer to dentry

 * @open: open callback

 * @opened: state of open

 *

 * This can be used to finish opening a file passed to i_op->atomic_open().

 *
@@ -1043,7 +1036,6 @@ EXPORT_SYMBOL(file_path); 
 * vfs_open - open the file at the given path

 * @path: path to open

 * @file: newly allocated file with f_flag initialized

 * @cred: credentials to use

 */

int vfs_open(const struct path *path, struct file *file)

{