Commit 555bda42 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Bartosz Golaszewski
Browse files

gpio: mpc8xxx: Fix a resources leak in the error handling path of 'mpc8xxx_probe()' 



Commit 698b8eea ("gpio/mpc8xxx: change irq handler from chained to normal")
has introduced a new 'goto err;' at the very end of the function, but has
not updated the error handling path accordingly.

Add the now missing 'irq_domain_remove()' call which balances a previous
'irq_domain_create_linear() call.

Fixes: 698b8eea ("gpio/mpc8xxx: change irq handler from chained to normal")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent 6b4a2a42

drivers/gpio/gpio-mpc8xxx.c

+2 −0
Original line number Diff line number Diff line
@@ -416,6 +416,8 @@ static int mpc8xxx_probe(struct platform_device *pdev) 


	return 0;

err:

	if (mpc8xxx_gc->irq)

		irq_domain_remove(mpc8xxx_gc->irq);

	iounmap(mpc8xxx_gc->regs);

	return ret;

}