Commit 55588713 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki Committed by Hans de Goede
Browse files

surface: surface3-wmi: Use ACPI_COMPANION() directly 



The ACPI_HANDLE() macro is a wrapper arond the ACPI_COMPANION()
macro and the ACPI handle produced by the former comes from the
ACPI device object produced by the latter, so it is way more
straightforward to evaluate the latter directly instead of passing
the handle produced by the former to acpi_bus_get_device().

Modify s3_wmi_check_platform_device() accordingly (no intentional
functional impact).

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: default avatarMaximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/12896717.uLZWGnKmhe@kreacher


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 603a7dd0

drivers/platform/surface/surface3-wmi.c

+4 −5
Original line number Diff line number Diff line
@@ -139,13 +139,12 @@ static acpi_status s3_wmi_attach_spi_device(acpi_handle handle, 


static int s3_wmi_check_platform_device(struct device *dev, void *data)

{

	struct acpi_device *adev, *ts_adev = NULL;

	acpi_handle handle;

	struct acpi_device *adev = ACPI_COMPANION(dev);

	struct acpi_device *ts_adev = NULL;

	acpi_status status;



	/* ignore non ACPI devices */

	handle = ACPI_HANDLE(dev);

	if (!handle || acpi_bus_get_device(handle, &adev))

	if (!adev)

		return 0;



	/* check for LID ACPI switch */
@@ -159,7 +158,7 @@ static int s3_wmi_check_platform_device(struct device *dev, void *data) 
	    strlen(SPI_CTL_OBJ_NAME)))

		return 0;



	status = acpi_walk_namespace(ACPI_TYPE_DEVICE, handle, 1,

	status = acpi_walk_namespace(ACPI_TYPE_DEVICE, adev->handle, 1,

				     s3_wmi_attach_spi_device, NULL,

				     &ts_adev, NULL);

	if (ACPI_FAILURE(status))