Commit 554e8b22 authored by Yihang Li's avatar Yihang Li
Browse files

scsi: libsas: Allocation SMP request is aligned to ARCH_DMA_MINALIGN 

driver inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I96KNQ
CVE: NA

----------------------------------------------------------------------

This series [1] reducing the kmalloc() minimum alignment on arm64 to 8
(from 128). In libsas, this will cause SMP requests to be 8-byte-aligned
through kmalloc() allocation. However, for the hisi_sas hardware, all
commands address must be 16-byte-aligned. Otherwise, the commands fail to
be executed.

ARCH_DMA_MINALIGN represents the minimum (static) alignment for safe DMA
operations, so use ARCH_DMA_MINALIGN as the alignment for SMP request.

Link: https://lkml.kernel.org/r/20230612153201.554742-1-catalin.marinas@arm.com

 [1]
Signed-off-by: default avatarYihang Li <liyihang9@huawei.com>
Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Reviewed-by: default avatarJohn Garry <john.g.garry@oracle.com>
Reviewed-by: default avatarJason Yan <yanaijie@huawei.com>
Signed-off-by: default avatarBing Xia <xiabing12@h-partners.com>
parent b0dacc0b

drivers/scsi/libsas/sas_expander.c

+1 −1
Original line number Diff line number Diff line
@@ -135,7 +135,7 @@ static int smp_execute_task(struct domain_device *dev, void *req, int req_size, 


static inline void *alloc_smp_req(int size)

{

	u8 *p = kzalloc(size, GFP_KERNEL);

	u8 *p = kzalloc(ALIGN(size, ARCH_DMA_MINALIGN), GFP_KERNEL);

	if (p)

		p[0] = SMP_REQUEST;

	return p;