Commit 550f9643 authored by Maor Dickman's avatar Maor Dickman Committed by Saeed Mahameed
Browse files

net/mlx5e: Fix wrong tc flag used when set hw-tc-offload off 



The cited commit reintroduced the ability to set hw-tc-offload
in switchdev mode by reusing NIC mode calls without modifying it
to support both modes, this can cause an illegal memory access
when trying to turn hw-tc-offload off.

Fix this by using the right TC_FLAG when checking if tc rules
are installed while disabling hw-tc-offload.

Fixes: d3cbd425 ("net/mlx5e: Add ndo_set_feature for uplink representor")
Signed-off-by: default avatarMaor Dickman <maord@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent f7a4e867

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

+3 −1
Original line number Diff line number Diff line
@@ -3682,7 +3682,9 @@ static int set_feature_hw_tc(struct net_device *netdev, bool enable) 
	int err = 0;



#if IS_ENABLED(CONFIG_MLX5_CLS_ACT)

	if (!enable && mlx5e_tc_num_filters(priv, MLX5_TC_FLAG(NIC_OFFLOAD))) {

	int tc_flag = mlx5e_is_uplink_rep(priv) ? MLX5_TC_FLAG(ESW_OFFLOAD) :

						  MLX5_TC_FLAG(NIC_OFFLOAD);

	if (!enable && mlx5e_tc_num_filters(priv, tc_flag)) {

		netdev_err(netdev,

			   "Active offloaded tc filters, can't turn hw_tc_offload off\n");

		return -EINVAL;