Commit 54ff1e3e authored by Kalesh AP's avatar Kalesh AP Committed by David S. Miller
Browse files

bnxt_en: add more error checks to HWRM_NVM_INSTALL_UPDATE 



FW returns error code "NVM_INSTALL_UPDATE_CMD_ERR_CODE_ANTI_ROLLBACK"
in the response to indicate that HWRM_NVM_INSTALL_UPDATE command has
failed due to Anti-rollback feature. Parse the error and return an
appropriate error code to the user.

Reviewed-by: default avatarSomnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: default avatarEdwin Peer <edwin.peer@broadcom.com>
Signed-off-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8e42aef0

drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

+4 −0
Original line number Diff line number Diff line
@@ -2609,6 +2609,10 @@ int bnxt_flash_package_from_fw_obj(struct net_device *dev, const struct firmware 
		cmd_err = ((struct hwrm_err_output *)resp)->cmd_err;



		switch (cmd_err) {

		case NVM_INSTALL_UPDATE_CMD_ERR_CODE_ANTI_ROLLBACK:

			netdev_err(dev, "HWRM_NVM_INSTALL_UPDATE failure Anti-rollback detected\n");

			rc = -EALREADY;

			break;

		case NVM_INSTALL_UPDATE_CMD_ERR_CODE_FRAG_ERR:

			install->flags =

				cpu_to_le16(NVM_INSTALL_UPDATE_REQ_FLAGS_ALLOWED_TO_DEFRAG);