Commit 54fe55fb authored by Chen-Yu Tsai's avatar Chen-Yu Tsai Committed by Linus Walleij
Browse files

pinctrl: mediatek: paris: Fix pingroup pin config state readback 



mtk_pconf_group_get(), used to read back pingroup pin config state,
simply returns a set of configs saved from a previous invocation of
mtk_pconf_group_set(). This is an unfiltered, unvalidated set passed
in from the pinconf core, which does not match the current hardware
state.

Since the driver library is designed to have one pin per group, pass
through mtk_pconf_group_get() to mtk_pinconf_get(), to read back the
current pin config state of the only pin in the group.

Also drop the assignment of pin config state to the group.

Fixes: 80525098 ("pinctrl: mediatek: add pinctrl-paris that implements the vendor dt-bindings")
Signed-off-by: default avatarChen-Yu Tsai <wenst@chromium.org>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20220308100956.2750295-5-wenst@chromium.org


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 19bce7ce

drivers/pinctrl/mediatek/pinctrl-paris.c

+3 −5
Original line number Diff line number Diff line
@@ -732,10 +732,10 @@ static int mtk_pconf_group_get(struct pinctrl_dev *pctldev, unsigned group, 
			       unsigned long *config)

{

	struct mtk_pinctrl *hw = pinctrl_dev_get_drvdata(pctldev);

	struct mtk_pinctrl_group *grp = &hw->groups[group];



	*config = hw->groups[group].config;



	return 0;

	 /* One pin per group only */

	return mtk_pinconf_get(pctldev, grp->pin, config);

}



static int mtk_pconf_group_set(struct pinctrl_dev *pctldev, unsigned group,
@@ -751,8 +751,6 @@ static int mtk_pconf_group_set(struct pinctrl_dev *pctldev, unsigned group, 
				      pinconf_to_config_argument(configs[i]));

		if (ret < 0)

			return ret;



		grp->config = configs[i];

	}



	return 0;