Commit 54d9135c authored by Ricardo Neri's avatar Ricardo Neri Committed by Rafael J. Wysocki
Browse files

thermal: intel: hfi: Improve the type of hfi_features::nr_table_pages 



A Coverity static code scan raised a potential overflow_before_widen
warning when hfi_features::nr_table_pages is used as an argument to
memcpy in intel_hfi_process_event().

Even though the overflow can never happen (the maximum number of pages of
the HFI table is 0x10 and 0x10 << PAGE_SHIFT = 0x10000), using size_t as
the data type of hfi_features::nr_table_pages makes Coverity happy and
matches the data type of the argument 'size' of memcpy().

Signed-off-by: default avatarRicardo Neri <ricardo.neri-calderon@linux.intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 247f34f7

drivers/thermal/intel/intel_hfi.c

+1 −1
Original line number Diff line number Diff line
@@ -137,7 +137,7 @@ struct hfi_instance { 
 * Parameters and supported features that are common to all HFI instances

 */

struct hfi_features {

	unsigned int	nr_table_pages;

	size_t		nr_table_pages;

	unsigned int	cpu_stride;

	unsigned int	hdr_size;

};