Commit 54c98d9d authored by Johan Hovold's avatar Johan Hovold
Browse files

USB: serial: xr: fix interface leak at disconnect 



Make sure to release the control interface at disconnect so that the
driver can be unbound without leaking resources (and later rebound).

Fixes: c2d405aa ("USB: serial: add MaxLinear/Exar USB to Serial driver")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent a38d2148

drivers/usb/serial/xr_serial.c

+10 −0
Original line number Diff line number Diff line
@@ -564,6 +564,15 @@ static int xr_probe(struct usb_serial *serial, const struct usb_device_id *id) 
	return 0;

}



static void xr_disconnect(struct usb_serial *serial)

{

	struct usb_driver *driver = serial->type->usb_driver;

	struct usb_interface *control_interface;



	control_interface = usb_ifnum_to_if(serial->dev, 0);

	usb_driver_release_interface(driver, control_interface);

}



static const struct usb_device_id id_table[] = {

	{ USB_DEVICE(0x04e2, 0x1410) }, /* XR21V141X */

	{ }
@@ -578,6 +587,7 @@ static struct usb_serial_driver xr_device = { 
	.id_table		= id_table,

	.num_ports		= 1,

	.probe			= xr_probe,

	.disconnect		= xr_disconnect,

	.open			= xr_open,

	.close			= xr_close,

	.break_ctl		= xr_break_ctl,