Commit 549bf94d authored by Krzysztof Wilczyński's avatar Krzysztof Wilczyński Committed by Lorenzo Pieralisi
Browse files

PCI: qcom-ep: Remove surplus dev_err() when using platform_get_irq_byname() 

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

This change is as per suggestions from Coccinelle, e.g.,
  drivers/pci/controller/dwc/pcie-qcom-ep.c:556:2-9: line 556 is redundant because platform_get_irq() already prints an error

Related:
  https://lore.kernel.org/all/20210310131913.2802385-1-kw@linux.com/
  https://lore.kernel.org/all/20200802142601.1635926-1-kw@linux.com/

Link: https://lore.kernel.org/r/20211027112931.37182-1-kw@linux.com


Signed-off-by: default avatarKrzysztof Wilczyński <kw@linux.com>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
parent 6e5ebc96

drivers/pci/controller/dwc/pcie-qcom-ep.c

+1 −3
Original line number Diff line number Diff line
@@ -552,10 +552,8 @@ static int qcom_pcie_ep_enable_irq_resources(struct platform_device *pdev, 
	int irq, ret;



	irq = platform_get_irq_byname(pdev, "global");

	if (irq < 0) {

		dev_err(&pdev->dev, "Failed to get Global IRQ\n");

	if (irq < 0)

		return irq;

	}



	ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,

					qcom_pcie_ep_global_irq_thread,