Commit 545665ad authored by Jack Wang's avatar Jack Wang Committed by Herbert Xu
Browse files

crypto: gemini - Fix error check for dma_map_sg 



dma_map_sg return 0 on error.

Cc: Corentin Labbe <clabbe@baylibre.com>
Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarJack Wang <jinpu.wang@ionos.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 28855860

drivers/crypto/gemini/sl3516-ce-cipher.c

+3 −3
Original line number Diff line number Diff line
@@ -149,7 +149,7 @@ static int sl3516_ce_cipher(struct skcipher_request *areq) 
	if (areq->src == areq->dst) {

		nr_sgs = dma_map_sg(ce->dev, areq->src, sg_nents(areq->src),

				    DMA_BIDIRECTIONAL);

		if (nr_sgs <= 0 || nr_sgs > MAXDESC / 2) {

		if (!nr_sgs || nr_sgs > MAXDESC / 2) {

			dev_err(ce->dev, "Invalid sg number %d\n", nr_sgs);

			err = -EINVAL;

			goto theend;
@@ -158,14 +158,14 @@ static int sl3516_ce_cipher(struct skcipher_request *areq) 
	} else {

		nr_sgs = dma_map_sg(ce->dev, areq->src, sg_nents(areq->src),

				    DMA_TO_DEVICE);

		if (nr_sgs <= 0 || nr_sgs > MAXDESC / 2) {

		if (!nr_sgs || nr_sgs > MAXDESC / 2) {

			dev_err(ce->dev, "Invalid sg number %d\n", nr_sgs);

			err = -EINVAL;

			goto theend;

		}

		nr_sgd = dma_map_sg(ce->dev, areq->dst, sg_nents(areq->dst),

				    DMA_FROM_DEVICE);

		if (nr_sgd <= 0 || nr_sgd > MAXDESC) {

		if (!nr_sgd || nr_sgd > MAXDESC) {

			dev_err(ce->dev, "Invalid sg number %d\n", nr_sgd);

			err = -EINVAL;

			goto theend_sgs;