Commit 5424a0b8 authored by Mikulas Patocka's avatar Mikulas Patocka Committed by Mike Snitzer
Browse files

dm: don't report "detected capacity change" on device creation



When a DM device is first created it doesn't yet have an established
capacity, therefore the use of set_capacity_and_notify() should be
conditional given the potential for needless pr_info "detected
capacity change" noise even if capacity is 0.

One could argue that the pr_info() in set_capacity_and_notify() is
misplaced, but that position is not held uniformly.

Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
Fixes: f64d9b2e ("dm: use set_capacity_and_notify")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
parent 2d669ceb
Loading
Loading
Loading
Loading
+4 −1
Original line number Diff line number Diff line
@@ -2036,6 +2036,9 @@ static struct dm_table *__bind(struct mapped_device *md, struct dm_table *t,
	if (size != dm_get_size(md))
		memset(&md->geometry, 0, sizeof(md->geometry));

	if (!get_capacity(md->disk))
		set_capacity(md->disk, size);
	else
		set_capacity_and_notify(md->disk, size);

	dm_table_event_callback(t, event_callback, md);