Commit 53ffa6a9 authored by 蒋家盛's avatar 蒋家盛 Committed by Benjamin Tissoires
Browse files

HID: amd_sfh: Add missing check for dma_alloc_coherent 



Add check for the return value of the dma_alloc_coherent since
it may return NULL pointer if allocation fails.

Fixes: 4b2c53d9 ("SFH:Transport Driver to add support of AMD Sensor Fusion Hub (SFH)")
Signed-off-by: default avatarJiasheng Jiang <jiasheng@iscas.ac.cn>
Acked-by: default avatarBasavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Link: https://lore.kernel.org/r/20221220024921.21992-1-jiasheng@iscas.ac.cn
parent 0ee29814

drivers/hid/amd-sfh-hid/amd_sfh_client.c

+4 −0
Original line number Diff line number Diff line
@@ -237,6 +237,10 @@ int amd_sfh_hid_client_init(struct amd_mp2_dev *privdata) 
		in_data->sensor_virt_addr[i] = dma_alloc_coherent(dev, sizeof(int) * 8,

								  &cl_data->sensor_dma_addr[i],

								  GFP_KERNEL);

		if (!in_data->sensor_virt_addr[i]) {

			rc = -ENOMEM;

			goto cleanup;

		}

		cl_data->sensor_sts[i] = SENSOR_DISABLED;

		cl_data->sensor_requested_cnt[i] = 0;

		cl_data->cur_hid_dev = i;