Commit 53d35b1a authored Apr 15, 2021 by Lorenzo Bianconi Committed by Felix Fietkau Apr 21, 2021

mt76: improve mcu error logging



Dump mcu command code in hex and related prefix to help debugging

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>

parent a8333801

drivers/net/wireless/mediatek/mt76/mt7603/mcu.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -21,9 +21,8 @@ mt7603_mcu_parse_response(struct mt76_dev *mdev, int cmd,
		struct mt7603_mcu_rxd *rxd;

		if (!skb) {
		dev_err(mdev->dev,
		"MCU message %d (seq %d) timed out\n",
		cmd, seq);
		dev_err(mdev->dev, "MCU message %02x (seq %d) timed out\n",
		abs(cmd), seq);
		dev->mcu_hang = MT7603_WATCHDOG_TIMEOUT;
		return -ETIMEDOUT;
		}

drivers/net/wireless/mediatek/mt76/mt7615/mcu.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -175,8 +175,8 @@ int mt7615_mcu_parse_response(struct mt76_dev *mdev, int cmd,
		int ret = 0;

		if (!skb) {
		dev_err(mdev->dev, "Message %ld (seq %d) timeout\n",
		cmd & MCU_CMD_MASK, seq);
		dev_err(mdev->dev, "Message %08x (seq %d) timeout\n",
		cmd, seq);
		return -ETIMEDOUT;
		}

drivers/net/wireless/mediatek/mt76/mt76x02_mcu.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -17,9 +17,8 @@ int mt76x02_mcu_parse_response(struct mt76_dev *mdev, int cmd,
		u32 *rxfce;

		if (!skb) {
		dev_err(mdev->dev,
		"MCU message %d (seq %d) timed out\n", cmd,
		seq);
		dev_err(mdev->dev, "MCU message %02x (seq %d) timed out\n",
		abs(cmd), seq);
		dev->mcu_timeout = 1;
		return -ETIMEDOUT;
		}

drivers/net/wireless/mediatek/mt76/mt7915/mcu.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -217,7 +217,7 @@ mt7915_mcu_parse_response(struct mt76_dev *mdev, int cmd,
		int ret = 0;

		if (!skb) {
		dev_err(mdev->dev, "Message %d (seq %d) timeout\n",
		dev_err(mdev->dev, "Message %08x (seq %d) timeout\n",
		cmd, seq);
		return -ETIMEDOUT;
		}

drivers/net/wireless/mediatek/mt76/mt7921/mcu.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -160,7 +160,7 @@ mt7921_mcu_parse_response(struct mt76_dev *mdev, int cmd,
		int ret = 0;

		if (!skb) {
		dev_err(mdev->dev, "Message %d (seq %d) timeout\n",
		dev_err(mdev->dev, "Message %08x (seq %d) timeout\n",
		cmd, seq);
		return -ETIMEDOUT;
		}