Commit 5391e0cb authored by Marc Kleine-Budde's avatar Marc Kleine-Budde
Browse files

can: gs_usb: gs_destroy_candev(): remove not needed usb_kill_anchored_urbs() 

In gs_destroy_candev(), the netdev is unregistered first, then all
anchored TX URBs (dev->tx_submitted) are disposed with
usb_kill_anchored_urbs().

The call to usb_kill_anchored_urbs() is not needed, as
unregister_candev() calls gs_can_close(), which already disposes the
TX URBS.

Remove not needed call to usb_kill_anchored_urbs() from
gs_destroy_candev().

Link: https://lore.kernel.org/all/20230718-gs_usb-cleanups-v1-10-c3b9154ec605@pengutronix.de


Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 5c6c313a

drivers/net/can/usb/gs_usb.c

+0 −1
Original line number Diff line number Diff line
@@ -1356,7 +1356,6 @@ static struct gs_can *gs_make_candev(unsigned int channel, 
static void gs_destroy_candev(struct gs_can *dev)

{

	unregister_candev(dev->netdev);

	usb_kill_anchored_urbs(&dev->tx_submitted);

	free_candev(dev->netdev);

}