Commit 537a1472 authored by Zhang Changzhong's avatar Zhang Changzhong Committed by Jakub Kicinski
Browse files

atl1c: fix error return code in atl1c_probe() 



Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 43250ddd ("atl1c: Atheros L1C Gigabit Ethernet driver")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/r/1605581721-36028-1-git-send-email-zhangchangzhong@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a5ebcbdf

drivers/net/ethernet/atheros/atl1c/atl1c_main.c

+2 −2
Original line number Diff line number Diff line
@@ -2543,8 +2543,8 @@ static int atl1c_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
	 * various kernel subsystems to support the mechanics required by a

	 * fixed-high-32-bit system.

	 */

	if ((dma_set_mask(&pdev->dev, DMA_BIT_MASK(32)) != 0) ||

	    (dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32)) != 0)) {

	err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));

	if (err) {

		dev_err(&pdev->dev, "No usable DMA configuration,aborting\n");

		goto err_dma;

	}