Commit 53615f69 authored by Camila Alvarez's avatar Camila Alvarez Committed by Yipeng Zou
Browse files

HID: cougar: fix slab-out-of-bounds Read in cougar_report_fixup 

stable inclusion
from stable-v4.19.322
commit e239e44dcd419b13cf840e2a3a833204e4329714
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/IARWXF
CVE: CVE-2024-46747

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e239e44dcd419b13cf840e2a3a833204e4329714



--------------------------------

report_fixup for the Cougar 500k Gaming Keyboard was not verifying
that the report descriptor size was correct before accessing it

Reported-by: default avatar <syzbot+24c0361074799d02c452@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=24c0361074799d02c452


Signed-off-by: default avatarCamila Alvarez <cam.alvarez.i@gmail.com>
Reviewed-by: default avatarSilvan Jegen <s.jegen@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
Signed-off-by: default avatarYipeng Zou <zouyipeng@huawei.com>
parent f2ffc6af

drivers/hid/hid-cougar.c

+1 −1
Original line number Diff line number Diff line
@@ -104,7 +104,7 @@ static void cougar_fix_g6_mapping(struct hid_device *hdev) 
static __u8 *cougar_report_fixup(struct hid_device *hdev, __u8 *rdesc,

				 unsigned int *rsize)

{

	if (rdesc[2] == 0x09 && rdesc[3] == 0x02 &&

	if (*rsize >= 117 && rdesc[2] == 0x09 && rdesc[3] == 0x02 &&

	    (rdesc[115] | rdesc[116] << 8) >= HID_MAX_USAGES) {

		hid_info(hdev,

			"usage count exceeds max: fixing up report descriptor\n");