Commit 535b3e05 authored by Masahiro Yamada's avatar Masahiro Yamada
Browse files

modpost: move export_from_secname() call to more relevant place 



The assigned 'export' is only used when

    if (strstarts(symname, "__ksymtab_"))

is met. The else-part of the assignment is the dead code.

Move the export_from_secname() call to where it is used.

Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
parent 7ce3e410

scripts/mod/modpost.c

+4 −6
Original line number Diff line number Diff line
@@ -684,14 +684,8 @@ static void handle_modversion(const struct module *mod, 
static void handle_symbol(struct module *mod, struct elf_info *info,

			  const Elf_Sym *sym, const char *symname)

{

	enum export export;

	const char *name;



	if (strstarts(symname, "__ksymtab"))

		export = export_from_secname(info, get_secindex(info, sym));

	else

		export = export_unknown;



	switch (sym->st_shndx) {

	case SHN_COMMON:

		if (strstarts(symname, "__gnu_lto_")) {
@@ -726,7 +720,11 @@ static void handle_symbol(struct module *mod, struct elf_info *info, 
	default:

		/* All exported symbols */

		if (strstarts(symname, "__ksymtab_")) {

			enum export export;



			name = symname + strlen("__ksymtab_");

			export = export_from_secname(info,

						     get_secindex(info, sym));

			sym_add_exported(name, mod, export);

		}

		if (strcmp(symname, "init_module") == 0)