Commit 532cfc0d authored by Yufeng Mo's avatar Yufeng Mo Committed by David S. Miller
Browse files

net: hns3: add a check for index in hclge_get_rss_key() 



The index is received from vf, if use it directly,
an out-of-bound issue may be caused, so add a check for
this index before using it in hclge_get_rss_key().

Fixes: a638b1d8 ("net: hns3: fix get VF RSS issue")
Signed-off-by: default avatarYufeng Mo <moyufeng@huawei.com>
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 326334aa

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c

+11 −0
Original line number Diff line number Diff line
@@ -607,6 +607,17 @@ static void hclge_get_rss_key(struct hclge_vport *vport, 


	index = mbx_req->msg.data[0];



	/* Check the query index of rss_hash_key from VF, make sure no

	 * more than the size of rss_hash_key.

	 */

	if (((index + 1) * HCLGE_RSS_MBX_RESP_LEN) >

	      sizeof(vport[0].rss_hash_key)) {

		dev_warn(&hdev->pdev->dev,

			 "failed to get the rss hash key, the index(%u) invalid !\n",

			 index);

		return;

	}



	memcpy(resp_msg->data,

	       &hdev->vport[0].rss_hash_key[index * HCLGE_RSS_MBX_RESP_LEN],

	       HCLGE_RSS_MBX_RESP_LEN);