Commit 5313b2a5 authored by Lucas Tanure's avatar Lucas Tanure Committed by Wei Liu
Browse files

HID: hyperv: NULL check before some freeing functions is not needed. 



Fix below warnings reported by coccicheck:
drivers/hid/hid-hyperv.c:197:2-7: WARNING: NULL check before some freeing functions is not needed.
drivers/hid/hid-hyperv.c:211:2-7: WARNING: NULL check before some freeing functions is not needed.

Signed-off-by: default avatarLucas Tanure <tanure@linux.com>
Reviewed-by: default avatarMichael Kelley <mikelley@microsoft.com>
Reviewed-by: default avatarWei Liu <wei.liu@kernel.org>
Acked-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: default avatarWei Liu <wei.liu@kernel.org>
parent 8c1b0767

drivers/hid/hid-hyperv.c

+2 −4
Original line number Diff line number Diff line
@@ -193,7 +193,6 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device, 
		goto cleanup;



	/* The pointer is not NULL when we resume from hibernation */

	if (input_device->hid_desc != NULL)

	kfree(input_device->hid_desc);

	input_device->hid_desc = kmemdup(desc, desc->bLength, GFP_ATOMIC);
@@ -207,7 +206,6 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device, 
	}



	/* The pointer is not NULL when we resume from hibernation */

	if (input_device->report_desc != NULL)

	kfree(input_device->report_desc);

	input_device->report_desc = kzalloc(input_device->report_desc_size,

					  GFP_ATOMIC);