Commit 52c795af authored by Roi Dayan's avatar Roi Dayan Committed by Saeed Mahameed
Browse files

net/mlx5e: Fix use-after-free when reverting termination table 



When having multiple dests with termination tables and second one
or afterwards fails the driver reverts usage of term tables but
doesn't reset the assignment in attr->dests[num_vport_dests].termtbl
which case a use-after-free when releasing the rule.
Fix by resetting the assignment of termtbl to null.

Fixes: 10caabda ("net/mlx5e: Use termination table for VLAN push actions")
Signed-off-by: default avatarRoi Dayan <roid@nvidia.com>
Reviewed-by: default avatarMaor Dickman <maord@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 3f5769a0

drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c

+2 −0
Original line number Diff line number Diff line
@@ -312,6 +312,8 @@ mlx5_eswitch_add_termtbl_rule(struct mlx5_eswitch *esw, 
	for (curr_dest = 0; curr_dest < num_vport_dests; curr_dest++) {

		struct mlx5_termtbl_handle *tt = attr->dests[curr_dest].termtbl;



		attr->dests[curr_dest].termtbl = NULL;



		/* search for the destination associated with the

		 * current term table

		 */