Commit 525d6515 authored Apr 28, 2022 by Yury Norov

drm/amd/pm: use bitmap_{from,to}_arr32 where appropriate



The smu_v1X_0_set_allowed_mask() uses bitmap_copy() to convert
bitmap to 32-bit array. This may be wrong due to endiannes issues.
Fix it by switching to bitmap_{from,to}_arr32.

CC: Alexander Gordeev <agordeev@linux.ibm.com>
CC: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC: Christian Borntraeger <borntraeger@linux.ibm.com>
CC: Claudio Imbrenda <imbrenda@linux.ibm.com>
CC: David Hildenbrand <david@redhat.com>
CC: Heiko Carstens <hca@linux.ibm.com>
CC: Janosch Frank <frankja@linux.ibm.com>
CC: Rasmus Villemoes <linux@rasmusvillemoes.dk>
CC: Sven Schnelle <svens@linux.ibm.com>
CC: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Yury Norov <yury.norov@gmail.com>

parent da0f8e95

drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -781,7 +781,7 @@ int smu_v11_0_set_allowed_mask(struct smu_context *smu)
		goto failed;
		}

		bitmap_copy((unsigned long *)feature_mask, feature->allowed, 64);
		bitmap_to_arr32(feature_mask, feature->allowed, 64);

		ret = smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_SetAllowedFeaturesMaskHigh,
		feature_mask[1], NULL);

drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -730,7 +730,7 @@ int smu_v13_0_set_allowed_mask(struct smu_context *smu)
		feature->feature_num < 64)
		return -EINVAL;

		bitmap_copy((unsigned long *)feature_mask, feature->allowed, 64);
		bitmap_to_arr32(feature_mask, feature->allowed, 64);

		ret = smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_SetAllowedFeaturesMaskHigh,
		feature_mask[1], NULL);