Commit 52579135 authored by Naftali Goldstein's avatar Naftali Goldstein Committed by Luca Coelho
Browse files

iwlwifi: d3: do not send the WOWLAN_CONFIGURATION command for netdetect 



This command should be used only when there's a real client station.
Currently it works, but since soon the driver will stop actually having
an auxiliary station by default, and this command requires _some_ valid
station, it needs to be removed from this flow.

Signed-off-by: default avatarNaftali Goldstein <naftali.goldstein@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20201209231352.81b2acfe292b.I8c7372e6f72279e22966a2d0a9066521f9d2f1a0@changeid


Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent a4450980

drivers/net/wireless/intel/iwlwifi/mvm/d3.c

+0 −14
Original line number Diff line number Diff line
@@ -955,7 +955,6 @@ iwl_mvm_netdetect_config(struct iwl_mvm *mvm, 
			 struct cfg80211_sched_scan_request *nd_config,

			 struct ieee80211_vif *vif)

{

	struct iwl_wowlan_config_cmd wowlan_config_cmd = {};

	int ret;

	bool unified_image = fw_has_capa(&mvm->fw->ucode_capa,

					 IWL_UCODE_TLV_CAPA_CNSLDTD_D3_D0_IMG);
@@ -975,19 +974,6 @@ iwl_mvm_netdetect_config(struct iwl_mvm *mvm, 
			return ret;

	}



	/* rfkill release can be either for wowlan or netdetect */

	if (wowlan->rfkill_release)

		wowlan_config_cmd.wakeup_filter |=

			cpu_to_le32(IWL_WOWLAN_WAKEUP_RF_KILL_DEASSERT);



	wowlan_config_cmd.sta_id = mvm->aux_sta.sta_id;



	ret = iwl_mvm_send_cmd_pdu(mvm, WOWLAN_CONFIGURATION, 0,

				   sizeof(wowlan_config_cmd),

				   &wowlan_config_cmd);

	if (ret)

		return ret;



	ret = iwl_mvm_sched_scan_start(mvm, vif, nd_config, &mvm->nd_ies,

				       IWL_MVM_SCAN_NETDETECT);

	if (ret)