Commit 525530ad authored by Yang Yingliang's avatar Yang Yingliang Committed by Alex Deucher
Browse files

drm/amdgpu/sdma: add missing release_firmware() in amdgpu_sdma_init_microcode() 



In some error path in amdgpu_sdma_init_microcode(), release_firmware() is
not called, the memory allocated in request_firmware() will be leaked,
calling amdgpu_sdma_destroy_inst_ctx() which calls release_firmware() to
avoid memory leak.

Fixes: 15aa1305 ("drm/amdgpu: add function to init SDMA microcode")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 8c39634d

drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c

+5 −3
Original line number Diff line number Diff line
@@ -222,8 +222,10 @@ int amdgpu_sdma_init_microcode(struct amdgpu_device *adev, 
		adev->sdma.instance[instance].fw->data;

	version_major = le16_to_cpu(header->header_version_major);



	if ((duplicate && instance) || (!duplicate && version_major > 1))

		return -EINVAL;

	if ((duplicate && instance) || (!duplicate && version_major > 1)) {

		err = -EINVAL;

		goto out;

	}



	err = amdgpu_sdma_init_inst_ctx(&adev->sdma.instance[instance]);

	if (err)
@@ -272,7 +274,7 @@ int amdgpu_sdma_init_microcode(struct amdgpu_device *adev, 
				ALIGN(le32_to_cpu(sdma_hdr->ctl_ucode_size_bytes), PAGE_SIZE);

			break;

		default:

			return -EINVAL;

			err = -EINVAL;

		}

	}