Commit 523dfa96 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Maíra Canal
Browse files

drm/tests: reduce drm_mm_test stack usage 



The check_reserve_boundaries function uses a lot of kernel stack,
and it gets inlined by clang, which makes __drm_test_mm_reserve
use even more of it, to the point of hitting the warning limit:

drivers/gpu/drm/tests/drm_mm_test.c:344:12: error: stack frame size (1048) exceeds limit (1024) in '__drm_test_mm_reserve' [-Werror,-Wframe-larger-than]

When building with gcc, this does not happen, but the structleak
plugin can similarly increase the stack usage and needs to be
disabled, as we do for all other kunit users.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarMaíra Canal <mcanal@igalia.com>
Reviewed-by: default avatarNathan Chancellor <nathan@kernel.org>
Signed-off-by: default avatarMaíra Canal <mairacanal@riseup.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20221215163511.266214-1-arnd@kernel.org
parent b02897e5

drivers/gpu/drm/tests/Makefile

+2 −0
Original line number Diff line number Diff line
@@ -12,3 +12,5 @@ obj-$(CONFIG_DRM_KUNIT_TEST) += \ 
	drm_mm_test.o \

	drm_plane_helper_test.o \

	drm_rect_test.o



CFLAGS_drm_mm_test.o := $(DISABLE_STRUCTLEAK_PLUGIN)

drivers/gpu/drm/tests/drm_mm_test.c

+3 −3
Original line number Diff line number Diff line
@@ -298,7 +298,7 @@ static bool expect_reserve_fail(struct kunit *test, struct drm_mm *mm, struct dr 
	return false;

}



static bool check_reserve_boundaries(struct kunit *test, struct drm_mm *mm,

static bool noinline_for_stack check_reserve_boundaries(struct kunit *test, struct drm_mm *mm,

							unsigned int count,

							u64 size)

{