Commit 5211cc87 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Steve French
Browse files

ksmbd: Use struct_size() helper in ksmbd_negotiate_smb_dialect() 

Prefer struct_size() over open-coded versions.

Link: https://github.com/KSPP/linux/issues/160


Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Acked-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
Reviewed-by: default avatarSergey Senozhatsky <senozhatsky@chromium.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 7b7d709e

fs/smb/server/smb_common.c

+1 −1
Original line number Diff line number Diff line
@@ -266,7 +266,7 @@ static int ksmbd_negotiate_smb_dialect(void *buf) 
		if (smb2_neg_size > smb_buf_length)

			goto err_out;



		if (smb2_neg_size + le16_to_cpu(req->DialectCount) * sizeof(__le16) >

		if (struct_size(req, Dialects, le16_to_cpu(req->DialectCount)) >

		    smb_buf_length)

			goto err_out;