Unverified Commit 51eea3a6 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mark Brown
Browse files

ASoC: mt6359: fix tests for platform_get_irq() failure 



The platform_get_irq() returns negative error codes.  It can't actually
return zero, but if it did that should be treated as success.

Fixes: eef07b9e ("ASoC: mediatek: mt6359: add MT6359 accdet jack driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YvThhr86N3qQM2EO@kili


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1ca72642

sound/soc/codecs/mt6359-accdet.c

+3 −3
Original line number Diff line number Diff line
@@ -965,7 +965,7 @@ static int mt6359_accdet_probe(struct platform_device *pdev) 
	mutex_init(&priv->res_lock);



	priv->accdet_irq = platform_get_irq(pdev, 0);

	if (priv->accdet_irq) {

	if (priv->accdet_irq >= 0) {

		ret = devm_request_threaded_irq(&pdev->dev, priv->accdet_irq,

						NULL, mt6359_accdet_irq,

						IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
@@ -979,7 +979,7 @@ static int mt6359_accdet_probe(struct platform_device *pdev) 


	if (priv->caps & ACCDET_PMIC_EINT0) {

		priv->accdet_eint0 = platform_get_irq(pdev, 1);

		if (priv->accdet_eint0) {

		if (priv->accdet_eint0 >= 0) {

			ret = devm_request_threaded_irq(&pdev->dev,

							priv->accdet_eint0,

							NULL, mt6359_accdet_irq,
@@ -994,7 +994,7 @@ static int mt6359_accdet_probe(struct platform_device *pdev) 
		}

	} else if (priv->caps & ACCDET_PMIC_EINT1) {

		priv->accdet_eint1 = platform_get_irq(pdev, 2);

		if (priv->accdet_eint1) {

		if (priv->accdet_eint1 >= 0) {

			ret = devm_request_threaded_irq(&pdev->dev,

							priv->accdet_eint1,

							NULL, mt6359_accdet_irq,