Unverified Commit 51e99de5 authored by Wolfram Sang's avatar Wolfram Sang Committed by Mark Brown
Browse files

spi: move from strlcpy with unused retval to strscpy 

Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.

Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/


Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20220818210107.7373-1-wsa+renesas@sang-engineering.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 9d08f700

drivers/spi/spi.c

+3 −3
Original line number Diff line number Diff line
@@ -753,7 +753,7 @@ struct spi_device *spi_new_device(struct spi_controller *ctlr, 
	proxy->max_speed_hz = chip->max_speed_hz;

	proxy->mode = chip->mode;

	proxy->irq = chip->irq;

	strlcpy(proxy->modalias, chip->modalias, sizeof(proxy->modalias));

	strscpy(proxy->modalias, chip->modalias, sizeof(proxy->modalias));

	proxy->dev.platform_data = (void *) chip->platform_data;

	proxy->controller_data = chip->controller_data;

	proxy->controller_state = NULL;
@@ -2330,7 +2330,7 @@ struct spi_device *spi_new_ancillary_device(struct spi_device *spi, 
		goto err_out;

	}



	strlcpy(ancillary->modalias, "dummy", sizeof(ancillary->modalias));

	strscpy(ancillary->modalias, "dummy", sizeof(ancillary->modalias));



	/* Use provided chip-select for ancillary device */

	ancillary->chip_select = chip_select;
@@ -2726,7 +2726,7 @@ static ssize_t slave_store(struct device *dev, struct device_attribute *attr, 
		if (!spi)

			return -ENOMEM;



		strlcpy(spi->modalias, name, sizeof(spi->modalias));

		strscpy(spi->modalias, name, sizeof(spi->modalias));



		rc = spi_add_device(spi);

		if (rc) {